Make IKOS available in the spaceros image (#99). #123
Conversation
|
Filing this as a draft. I built it locally and checked that ikos was building and running during compilation. I'd like to check that it's available in the result. I could use a couple of extra eyes. It does not take a hugely long time to compile. EDIT: I just checked that it's available in the result. I had to move the IKOS build to the |
ivanperez-keera
force-pushed
the
dev-ikos
branch
from
32bb319 to
35df586
Compare
IKOS is one of the tools that Space ROS includes to perform static analysis of ROS 2 applications. Although ament_ikos is provided with the docker image, IKOS itself is not, rendering the former useless and leaving it to users to compile and install IKOS prior to being able to use it. This commit modifies the spaceros Earthfile to install IKOS globally in the system.
ivanperez-keera
force-pushed
the
dev-ikos
branch
from
35df586 to
4958c4f
Compare
|
This is ready for review, if anyone wants to take it. |
|
Have you checked if #104 is fixed by this PR? If not i can dig into artifact output and check. |
|
@xfiderek I have not, and I don't want to add that to this release. We are getting dangerously close; I think it's best that we first close the items assigned to this release that we have not finished yet. |
|
@xfiderek can I trouble you to review this PR? It can't be merged until someone approves. Thanks! |
|
Upps. "At least 1 approving review is required by reviewers with write access" |
|
Sorry, @xfiderek . It appears that it needs a review also from someone with write access. I've asked for an additional review. Thanks for approving it though :) |
|
Ok, btw after this PR is merged lets create an issue to track status of apt availability, something like "install ikos from deb". Does it make sense? |
|
Maybe we can have a quick talk about how to best do this. I'm available to talk / call. We definitely need to track it, but what's odd about this kind of issue is that instead of us doing something, it's in "waiting" or "on hold" until someone else does something. Perhaps it should be a discussion instead of an issue, or it should be a task in my personal agenda as opposed to an issue in the docker. There's also the possibility that they might say "no" to both accepting IKOS in debian as |
|
And just for full context: https://ftp-master.debian.org/new/ikos_3.2-1.html. It can take months for that to be processed because of the strange license. The debian dev that put that there has been supernice about helping us; we just have to be very patient. |
|
@ivanperez-keera sorry, I could not reply earlier. Personally I am fine with whatever you decide. Since you are actively involved in IKOS dev, we have first-hand news and I find it hard to believe that it will slip out of your mind :). |
Fix outdated usage and comments in `generate-repos.sh`
…en_text Fix outdated usage and comments in `generate-repos.sh`
IKOS is one of the tools that Space ROS includes to perform static analysis of ROS 2 applications. Although ament_ikos is provided with the docker image, IKOS itself is not, rendering the former useless and leaving it to users to compile and install IKOS prior to being able to use it.
This commit modifies the spaceros Earthfile to install IKOS globally in the system.